Fix Electron onSendError callbacks not being called
#1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using 'runSyncCallbacks' from core ensures the behaviour of onSendError callbacks matches onError callbacks Notably errors will be caught, logged and won't stop subsequent callbacks from being called The callback array is now treated like a stack, i.e. the most recently added callback is called first (LIFO) rather than last (FIFO/a queue)
This allows using the Event API (addMetadata etc...) inside the callback. Otherwise users would have to know the internal JSON representation of an Event in order to mutate it
gingerbenw
approved these changes
Aug 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The
onSendErrorconfiguration option was not being passed down to the minidump delivery loop and so was not being calledWere this to work, it would also have been passed the an Event in its JSON serialised form rather than a real Event object (see equivalent option in Android & Cocoa)
This PR fixes the bug causing
onSendErrorto not be applied and deserialises the Event JSON into an Event object